update curriculum builder banner link targets #44998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
changed the title
dmcavoy
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes Step 2 from https://codedotorg.atlassian.net/browse/PLAT-1601. We use config in our main repo to control where redirects like https://curriculum.code.org/csf-current go to. This PR updates that config.
Once this is deployed, the curriculum builder edit UI can be used to add banners to HOC courses pointing to https://curriculum.code.org/hoc-current .
Testing story
TESTING UPDATE: I followed the instructions at the top of the script to deploy these changes, and verified that the redirects are working from the banners on csf / csd / csp pages on CB, as well as when navigating directly to curriculum.code.org/hoc-current/ .
I have not tested this. I will keep an eye out during the deploy. if something goes wrong, the original config can be restored manually at https://s3.console.aws.amazon.com/s3/bucket/cdo-curriculum/property/website/edit?region=us-east-1 .