Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javalab: pass host name to upload request and convert grid to JSON #45005

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

sanchitmalhotra126
Copy link
Contributor

A couple of small fixes to the Javabuilder upload project code:

  • pass the host name and set the Origin header on the PUT request - this is needed because the Javabuilder authorizer lambda uses the Origin header to decided which public key to use to decode the Auth token.
  • convert the maze file to JSON. Currently, it's converted to a string in Ruby hash syntax which prevented Javabuilder from parsing it correctly.

Links

Testing story

Testing: confirmed that PUT requests succeeds on both localhost and via API Gateway (using a prototype API Gateway endpoint), and confirmed that the maze file is successfully parsed as JSON in Javabuilder.

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sanchitmalhotra126 sanchitmalhotra126 requested a review from a team February 23, 2022 22:38
@sanchitmalhotra126 sanchitmalhotra126 merged commit 9533bb4 into staging Feb 24, 2022
@sanchitmalhotra126 sanchitmalhotra126 deleted the javabuilder-upload-fixes branch February 24, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants