Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gold Superhero Banners, Styling Changes #45013

Merged
merged 7 commits into from
Mar 1, 2022

Conversation

hannahbergam
Copy link
Contributor

@hannahbergam hannahbergam commented Feb 24, 2022

This Pr represents several updates to the superhero banner, including bold headers, dynamic text sizing with page resizing between sizes, button formatting, a removal of the whitespace buffer, new line spacing, etc.
The desktop font size goes as large as 26 (header) and 17 (body), and is capped at that size beyond a screen size of 1440. The smallest font is 14 to comply with accessibility guidelines.

It also adds new gold banners and gold vs. blue backgrounds depending on homepage vs. not. Finally, it updates the Coldplay Hero banner by shifting the button up (by 40px) closer to the text, and making "Try it" bold.

Old desktop on homepage:
Screen Shot 2022-02-25 at 11 30 25 AM
New desktop on homepage:
Screen Shot 2022-02-25 at 11 27 46 AM

Old tablet on homepage:
Screen Shot 2022-02-25 at 11 30 10 AM
New tablet on homepage:
Screen Shot 2022-02-25 at 11 28 01 AM

Old mobile on homepage:
Screen Shot 2022-02-25 at 11 29 55 AM
New mobile on homepage:
Screen Shot 2022-02-28 at 2 20 27 PM

Old desktop on other pages:
Screen Shot 2022-02-25 at 11 30 37 AM
New desktop on other pages:
Screen Shot 2022-02-28 at 2 23 33 PM

Old tablet on other pages:
Screen Shot 2022-02-25 at 11 30 46 AM
New tablet on other pages:
Screen Shot 2022-02-28 at 2 45 43 PM

Old mobile on other pages:
Screen Shot 2022-02-25 at 11 30 56 AM
New mobile on other pages:
Screen Shot 2022-02-28 at 2 21 13 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@hannahbergam hannahbergam requested a review from a team February 25, 2022 19:37
Copy link
Contributor

@maureensturgeon maureensturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannahbergam hannahbergam merged commit 54b52a1 into staging Mar 1, 2022
@hannahbergam hannahbergam deleted the hbergam/marketing-banners branch March 1, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants