New Gold Superhero Banners, Styling Changes #45013
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pr represents several updates to the superhero banner, including bold headers, dynamic text sizing with page resizing between sizes, button formatting, a removal of the whitespace buffer, new line spacing, etc.
The desktop font size goes as large as 26 (header) and 17 (body), and is capped at that size beyond a screen size of 1440. The smallest font is 14 to comply with accessibility guidelines.
It also adds new gold banners and gold vs. blue backgrounds depending on homepage vs. not. Finally, it updates the Coldplay Hero banner by shifting the button up (by 40px) closer to the text, and making "Try it" bold.
Old desktop on homepage:
New desktop on homepage:
Old tablet on homepage:
New tablet on homepage:
Old mobile on homepage:
New mobile on homepage:
Old desktop on other pages:
New desktop on other pages:
Old tablet on other pages:
New tablet on other pages:
Old mobile on other pages:
New mobile on other pages:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: