[Sprite Lab] Test for workspace alert #45099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -40,11 +41,11 @@ describe('SpriteLab', () => { | |||
| }); | |||
| afterEach(() => document.body.removeChild(container)); | |||
|
|
|||
| let studioApp; | |||
| let testStudioApp; | |||
There was a problem hiding this comment.
naming nit: in unit tests a "fake" version of something usually called a "mock"; this object is a mock version of StudioApp, so the convention would be mockStudioApp (which also means your rename here is how it originally should've been named!)
There was a problem hiding this comment.
there are multiple ways to fake things in unit tests, too, as you've shown in your changes here. this is a good article about the difference between the two most common fakes, mocks and stubs: https://martinfowler.com/articles/mocksArentStubs.html
Comment on lines
154
to
156
| workspaceAlertError: () => { | ||
| return 'translated string'; | ||
| } |
There was a problem hiding this comment.
we can simplify this expression with ES6 arrow function expressions
maddiedierker
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #45055, which adds a workspace alert for execution errors in Sprite Lab. We should also add a test to be sure this is working as intended.
Due to a naming conflict, we can rename an existing use of
studioAppand reserve that label for the singleton that is imported. (See new line 23 and changes to lines ~43 to ~65).Created Jira ticket STAR-2127 as a subtask of STAR-2099 to track.