Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove multiple hostnames from startWebRequest #45121

Merged
merged 1 commit into from Mar 2, 2022

Conversation

KylieModen
Copy link
Contributor

After completing a comprehensive review of all allowed hostnames, the following five are being removed:

  1. apex.oracle.com - the documentation seems to indicate this would just allow for querying of a database the student/teacher has access to https://docs.oracle.com/en/database/oracle/application-express/20.2/aeapi/preface.html - given the risk for arbitrary content, removing (we also don't think students/teachers would have access to many if any Oracle databases to use this API).

  2. enclout.com- this is a domain, Entity and Language processing API, we saw cert expired and thus are removing.

  3. herokuapp.com - it was unclear what the original reasoning for this hostname being added - the hostname is a risk to us allowing arbitrary content to be passed to App Lab and has caused multiple reports on the teacher forums.

  4. pastebin.com - this API stores online text, removed as we do not want to support arbitrary text access in our allowed hostnames and such use cases can be met with the data tables in App Lab.

  5. spreadsheets.google.com - This API no longer works as there are no references to it from https://developers.google.com/sheets/api/reference/rest and we know the sheets API does not work for us due to its forward redirects

Zendesk ticket: https://codedotorg.atlassian.net/browse/STAR-2040

After completing a comprehensive review of all allowed hostnames, the following five are being removed: 

1. apex.oracle.com - the documentation seems to indicate this would just allow for querying of a database the student/teacher has access to https://docs.oracle.com/en/database/oracle/application-express/20.2/aeapi/preface.html - given the risk for arbitrary content, removing (we also don't think students/teachers would have access to many if any Oracle databases to use this API).

2. enclout.com- this is a domain, Entity and Language processing API, we saw cert expired and thus are removing. 

3. herokuapp.com - it was unclear what the original reasoning for this hostname being added - the hostname is a risk to us allowing arbitrary content to be passed to App Lab and has caused multiple reports on the teacher forums.

4. pastebin.com - this API stores online text, removed as we do not want to support arbitrary text access in our allowed hostnames and such use cases can be met with the data tables in App Lab.

5. spreadsheets.google.com - This API no longer works as there are no references to it from https://developers.google.com/sheets/api/reference/rest and we know the sheets API does not work for us due to its forward redirects 

Zendesk ticket: https://codedotorg.atlassian.net/browse/STAR-2040
@KylieModen KylieModen requested a review from a team March 2, 2022 19:25
Copy link

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I think these are all good hostnames to remove!

@KylieModen KylieModen merged commit afbd0ac into staging Mar 2, 2022
@KylieModen KylieModen deleted the KylieModen-patch-3 branch March 2, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants