Remove multiple hostnames from startWebRequest #45121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After completing a comprehensive review of all allowed hostnames, the following five are being removed:
apex.oracle.com - the documentation seems to indicate this would just allow for querying of a database the student/teacher has access to https://docs.oracle.com/en/database/oracle/application-express/20.2/aeapi/preface.html - given the risk for arbitrary content, removing (we also don't think students/teachers would have access to many if any Oracle databases to use this API).
enclout.com- this is a domain, Entity and Language processing API, we saw cert expired and thus are removing.
herokuapp.com - it was unclear what the original reasoning for this hostname being added - the hostname is a risk to us allowing arbitrary content to be passed to App Lab and has caused multiple reports on the teacher forums.
pastebin.com - this API stores online text, removed as we do not want to support arbitrary text access in our allowed hostnames and such use cases can be met with the data tables in App Lab.
spreadsheets.google.com - This API no longer works as there are no references to it from https://developers.google.com/sheets/api/reference/rest and we know the sheets API does not work for us due to its forward redirects
Zendesk ticket: https://codedotorg.atlassian.net/browse/STAR-2040