Add workshop box for teachers with RPs that don't offer CSA #45137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2022 07:11
tim-dot-org
approved these changes
Mar 4, 2022
| workshops: | ||
| partnerInfo && | ||
| partnerInfo.summer_workshops.filter( | ||
| workshop => workshop.course === 'CS Discoveries' | ||
| workshop => workshop.course === `${ActiveCourseWorkshops.CSD}` |
There was a problem hiding this comment.
tiny nit: these are already strings, so they don't need to be wrapped
There was a problem hiding this comment.
otherwise, looks great!
tim-dot-org
reviewed
Mar 4, 2022
| @@ -303,9 +304,32 @@ class RegionalPartnerSearch extends Component { | |||
| collection => collection.workshops.length === 0 | |||
| ) && <div>Workshop details coming soon!</div>} | |||
There was a problem hiding this comment.
maybe a weird quirk, if there are no workshops at all, it'll show this text and also the CSA text
There was a problem hiding this comment.
Strong point––I'll check with Tess what we want to do in that situation
There was a problem hiding this comment.
She says it's not a huge deal since this won't happen next year, but I'll add something for it
There was a problem hiding this comment.
Just tweaked it––new screenshots for workshops, and then if there are no workshops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if CSA workshops are available in their region, teachers will see this
If CSA workshops are not available in their region, teachers see this
With the new functionality, teachers see this if there are no CSA workshops (screenshot of local environment––I didn't set RP information for
appsPriorityDeadlineDateso no call to action):And nothing changes if there are CSA workshops (screenshot of local environment––I didn't set RP information for
appsPriorityDeadlineDateso no call to action):Links
Testing story
Deployment strategy
Follow-up work
I created a follow-up ticket for test coverage: https://codedotorg.atlassian.net/browse/PLAT-1650.
Description:
The RegionalPartnerSearch has 0 test coverage. Right now, trying to add test coverage results in errors about how we are setting state in the component:
Can't call %s on a component that is not yet mounted. This is a no-op, but it might indicate a bug in your application. Instead, assign tothis.statedirectly or define astate = {};class property with the desired state in the %s component.We should probably refactor this component to use hooks, which would allow us to avoid mounting the component to test it.
Privacy
Security
Caching
PR Checklist: