New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links on programming environment index and in the grey box #45146

Merged

bethanyaconnor merged 2 commits into staging from fix-code-docs-links

Mar 7, 2022

Contributor

bethanyaconnor commented Mar 3, 2022

On /programming_environments, link to new programming environment pages (so /programming_environments/gamelab for example at this point)
In the grey box on non-levelbuilder environments, link to the programming expression overview. This fixes an issue where the link went to a different programming expression. There isn't an edit link that will work cross-environment, so linking to the overview page will work for now

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          Fix links on programming environment index and in the grey box

d52cee2

bethanyaconnor requested a review from a team

March 3, 2022 22:32

jamescodeorg approved these changes

View reviewed changes


          Update test with new prop

9e179ca

bethanyaconnor merged commit 1a39f1c into staging

bethanyaconnor deleted the fix-code-docs-links branch

March 7, 2022 16:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment