Update the panebuttons to support tab navigation #45162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
reviewed
Mar 4, 2022
| function onKeyDownWrapper(event) { | ||
| const {onClick} = props; | ||
| if ( | ||
| event.key === ' ' || |
There was a problem hiding this comment.
This is new to me - what key does this represent?
There was a problem hiding this comment.
Oof. To be completely honest, I'm not sure either 😬. I copied it straight from here: https://benfrain.com/converting-divs-into-accessible-pseudo-buttons/
There was a problem hiding this comment.
Oh huh. Looks like it's the newer version of "SpaceBar"
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/key/Key_Values
epeach
reviewed
Mar 4, 2022
apps/src/templates/PaneHeader.jsx
Outdated
| return ( | ||
| <div | ||
| role="button" | ||
| tabIndex={0} |
There was a problem hiding this comment.
Nit - I don't think this needs to be an object, I think it can just be a string - "0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a quick update to make the PaneButton subcomponent of PaneHeader tab navigable.
Before
After
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: