Move integration tests #45175
Merged
Move integration tests #45175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
March 3, 2022 14:57
megcrenshaw
commented
Mar 7, 2022
| // Also calls firehose event on submit, but we reload the page on submit | ||
| // The page reload can't be stubbed because `window.location.reload` | ||
| // is not writable nor configurable: Object.getOwnPropertyDescriptor(window.location, 'toString') | ||
| // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/defineProperty#modifying_a_property |
There was a problem hiding this comment.
I spent too long on this 😅 . We could do the window.location.reload in a separate function that we stub out, but then we'd have to export that function for the test here. I don't think there's a "good" way to test this––open to ideas
There was a problem hiding this comment.
so we actually do have a util already specifically for this purpose:
code-dot-org/apps/src/utils.js
Lines 725 to 727 in 1274ce4
There was a problem hiding this comment.
Ooo excellent––will update this!
tim-dot-org
approved these changes
Mar 7, 2022
|
thank you for doing this Meg! This seems like a step in the right direction. it would be great for our engineering team to get on the same page about js integration tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the TeacherApplication test refactor, I moved the tests requiring
mountto a separate file. I originally had these in theintegrationdirectory, but I had to import enzyme for it to work (see 14d5c23). Instead, I kept it in theunitdirectory but with a different name.Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: