Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code docs examples iframe spacing and cut off #45269

Merged
merged 1 commit into from Mar 11, 2022
Merged

Fix code docs examples iframe spacing and cut off #45269

merged 1 commit into from Mar 11, 2022

Conversation

maureensturgeon
Copy link
Contributor

@maureensturgeon maureensturgeon commented Mar 11, 2022 •
edited

Removes some of the white space below the iframe and fixes the cut-off.

Before:
Screen Shot 2022-03-10 at 5 24 40 PM
After:
Screen Shot 2022-03-10 at 5 23 23 PM

Before:
Screen Shot 2022-03-10 at 5 24 52 PM
After:
Screen Shot 2022-03-10 at 5 23 31 PM

Before:
Screen Shot 2022-03-10 at 5 25 00 PM
After:
Screen Shot 2022-03-10 at 5 23 37 PM

Links

Testing story

Tested locally

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@maureensturgeon maureensturgeon marked this pull request as ready for review March 11, 2022 01:27
@maureensturgeon maureensturgeon requested a review from a team March 11, 2022 01:28
bethanyaconnor
bethanyaconnor approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 looks great!

@maureensturgeon maureensturgeon merged commit 9fa6e2c into staging Mar 11, 2022
@maureensturgeon maureensturgeon deleted the maureen/PLAT-1646-code-docs-iframes branch March 11, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maureensturgeon @bethanyaconnor