Java Lab: Run validation code in start mode #45500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanchitmalhotra126
approved these changes
Mar 28, 2022
Comment on lines
40
to
41
| // Get the access token to connect to javabuilder and then open the websocket connection. | ||
| // The token prevents access to our javabuilder AWS execution environment by un-verified users. |
There was a problem hiding this comment.
nit: mind adding to this comment describing when we'd use this as opposed to the other functions? just want to make sure we document that this is meant for typical student code execution vs the other two are special cases
Comment on lines
80
to
84
| const ajaxPayload = { | ||
| url: '/javabuilder/access_token_with_override_validation', | ||
| type: 'get', | ||
| data: requestData | ||
| }; |
There was a problem hiding this comment.
nit: instead of creating the full payload each time, connectJavabuilderHelper could take in a url and requestData param? it's a small change though so I'm fine with this as well
Comment on lines
+141
to
+142
| # To use a developer instance of Javabuilder instead, replace this url with | ||
| # 'wss://<your-javabuilder-domain>.dev-code.org' |
There was a problem hiding this comment.
Thanks for adding these!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow validation code that has not yet been saved to the level to be run in start mode. This PR created the route we use here. If we are in start mode and are doing a test run, we use this route, which passes whatever validation code is currently in the editor. We don't need to use this route for a regular run because validation code is ignored on a normal run.
I also did a minor refactor of our connect logic since we now have 3 different routes. Instead of passing in parameters for each potential option and doing an if/else we now have 3 separate functions.
As part of this PR I also added a comment to
cdo.rbwith the format for dev javabuilder routes, because I kept having to put my route there for testing.Links
Testing story
Tested locally against deployed Javabuilder.
PR Checklist: