Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seed/serialize ProgrammingClass #45554

Merged
merged 3 commits into from Apr 1, 2022

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Mar 29, 2022

Adds seed and serializing ProgrammingClass! If editing starts before this is in, work could be lost so I wanted to get this in before then. Methods will also need to be serialized, but I'll add that logic later.

It'll write something like:

{
  "category_key": null,
  "content": null,
  "examples": null,
  "external_documentation": null,
  "fields": null,
  "key": "vector",
  "name": "vector",
  "syntax": null,
  "tips": null
}

I based this logic very heavily on the ProgrammingExpression seeding logic here.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review March 31, 2022 15:38
@bethanyaconnor bethanyaconnor requested review from a team March 31, 2022 15:38
Copy link
Contributor

@maureensturgeon maureensturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a ton of context, but from what I can tell, looks good to me!

@bethanyaconnor bethanyaconnor merged commit db64d25 into staging Apr 1, 2022
@bethanyaconnor bethanyaconnor deleted the bethany/seed-serialize-programming-class branch April 1, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants