-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DTL (Test > Levelbuilder: ac61a323) #45739
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y, this enabled read-write splitting on test
…-plus-read-splitting-on-test
…at involves writing
…-plus-read-splitting-on-test
… year if not in development
Fix everyInterval block
…ripts-for-storage-apps Update remaining references to storage_apps and user_storage_ids
DTT (Staging > Test) [robo-dtt]
…out-course-offering Do not allow saving standalone script without family name and version_year outside of in_development
Add Course Offerings for all Course Versions
DTT (Staging > Test) [robo-dtt]
…ng-on-test Upgrade to Rails 6.0.4.1 and Enable Read Splitting on Test
DTT (Staging > Test) [robo-dtt]
As used in /thebadguys. Also affects /poetry & /helloworld but looks fine on them.
This helper is referenced extensively from within view code, including in at least one view that is currently being pointed at the read replica. Unfortunately, it also does some incidental writes. Specifically, one which tracks the progress of students in sections: ActionView::Template::Error at /s/allthethings/lessons/2/levels/4 ================================================================= > Mysql2::Error: UPDATE command denied to user 'reader'@'localhost' for table 'sections' app/views/levels/show.html.haml, line 69 ---------------------------------------- ``` ruby 64 - else 65 = render partial: "levels/#{@level.class.to_s.underscore}" 66 - unless @level.is_a?(StandaloneVideo) || @level.properties['hide_reference_area'] 67 = render partial: 'levels/reference_area' 68 - else > 69 = render partial: 'levels/blockly' 70 71 - if @peer_reviews.present? 72 = render partial: 'peer_reviews/viewer' 73 74 - if tracking_pixel_enabled && @script.try(:hoc?) && (@script_level.try(:chapter) == 1 || @script_level.try(:position) == 1) ```
…in-app_options Explicitly use the Write Connection for Writes inside `app_options`
DTT (Staging > Test) [robo-dtt]
…ct-tweak The Bad Guys: make featured project images square
DTT (Staging > Test) [robo-dtt]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.