Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTL (Test > Levelbuilder: ac61a323) #45739

Merged
merged 43 commits into from
Apr 8, 2022
Merged

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 8, 2022

No description provided.

Hamms and others added 30 commits March 1, 2022 15:02
…y, this enabled read-write splitting on test
…ripts-for-storage-apps

Update remaining references to storage_apps and user_storage_ids
deploy-code-org and others added 13 commits April 7, 2022 13:08
DTT (Staging > Test) [robo-dtt]
…out-course-offering

Do not allow saving standalone script without family name and version_year outside of in_development
Add Course Offerings for all Course Versions
DTT (Staging > Test) [robo-dtt]
…ng-on-test

Upgrade to Rails 6.0.4.1 and Enable Read Splitting on Test
DTT (Staging > Test) [robo-dtt]
As used in /thebadguys.  Also affects /poetry & /helloworld but looks fine on them.
This helper is referenced extensively from within view code, including in at least one view that is currently being pointed at the read replica.

Unfortunately, it also does some incidental writes. Specifically, one which tracks the progress of students in sections:

    ActionView::Template::Error at /s/allthethings/lessons/2/levels/4
    =================================================================

    > Mysql2::Error: UPDATE command denied to user 'reader'@'localhost' for table 'sections'

    app/views/levels/show.html.haml, line 69
    ----------------------------------------

    ``` ruby
       64         - else
       65           = render partial: "levels/#{@level.class.to_s.underscore}"
       66         - unless @level.is_a?(StandaloneVideo) || @level.properties['hide_reference_area']
       67           = render partial: 'levels/reference_area'
       68       - else
    >  69         = render partial: 'levels/blockly'
       70
       71     - if @peer_reviews.present?
       72       = render partial: 'peer_reviews/viewer'
       73
       74   - if tracking_pixel_enabled && @script.try(:hoc?) && (@script_level.try(:chapter) == 1 || @script_level.try(:position) == 1)
    ```
…in-app_options

Explicitly use the Write Connection for Writes inside `app_options`
DTT (Staging > Test) [robo-dtt]
…ct-tweak

The Bad Guys: make featured project images square
DTT (Staging > Test) [robo-dtt]
@dmcavoy dmcavoy requested a review from a team as a code owner April 8, 2022 12:10
@dmcavoy dmcavoy merged commit 77f3fd2 into levelbuilder Apr 8, 2022
@dmcavoy dmcavoy deleted the dtl_candidate_ac61a323 branch April 8, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants