-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Joined Sections Area for PL Sections #45761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
commented
Apr 13, 2022
davidsbailey
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Dani!
error message looks good to me - would only add "If you think this is a mistake please reach out to support@code.org for assistance" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of preparing for launching PL courses and being able to create PL sections.
It creates a separate table on the TeacherHomepage for PL sections that a teacher account has joined. In addition it pulls out the JoinSection component into its own separate area above both the joined student sections and joined pl sections areas. The joined PL sections area will only show if you have joined a pl section and since there are currently no pl sections (we haven't added the ability to create pl sections yet) this is space to merge ahead of launching PL sections and courses.
If you try to join a section and you can not be a participant in that section this error will show (@tess323 looking for your input on the message here):
If there are no student sections and pl sections then only the Join A Section area will show
Links
ENG plan
Product Spec
Jira
Testing story