Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Joined Sections Area for PL Sections #45761

Merged
merged 16 commits into from
Apr 14, 2022

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Apr 9, 2022

This PR is part of preparing for launching PL courses and being able to create PL sections.

It creates a separate table on the TeacherHomepage for PL sections that a teacher account has joined. In addition it pulls out the JoinSection component into its own separate area above both the joined student sections and joined pl sections areas. The joined PL sections area will only show if you have joined a pl section and since there are currently no pl sections (we haven't added the ability to create pl sections yet) this is space to merge ahead of launching PL sections and courses.

Screen Shot 2022-04-11 at 10 34 50 PM

If you try to join a section and you can not be a participant in that section this error will show (@tess323 looking for your input on the message here):

Screen Shot 2022-04-13 at 8 25 48 PM

If there are no student sections and pl sections then only the Join A Section area will show

Screen Shot 2022-04-13 at 8 28 11 PM

Links

ENG plan
Product Spec
Jira

Testing story

  • Added and update unit tests
  • Manual testing locally where I have some PL sections

@dmcavoy dmcavoy requested a review from a team as a code owner April 13, 2022 19:07
@dmcavoy dmcavoy requested review from a team and removed request for a team April 14, 2022 00:29
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great Dani!

apps/src/templates/studioHomepages/JoinSectionArea.jsx Outdated Show resolved Hide resolved
@dmcavoy dmcavoy merged commit 2444558 into staging Apr 14, 2022
@dmcavoy dmcavoy deleted the eptools/dani/assigning-pl-sections branch April 14, 2022 03:45
@tess323
Copy link

tess323 commented Apr 14, 2022

error message looks good to me - would only add "If you think this is a mistake please reach out to support@code.org for assistance"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants