Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that generated project IDs are greater than 0 for tests #45776

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

sanchitmalhotra126
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 commented Apr 11, 2022

A test in a recent DTT failed because when trying to create a new Project, the random project ID that was generated was 0. Project IDs are expected to be integers > 0. This ensures that the random project ID that's generated is always greater than 0.

Generated stack trace of the failing test:
Screen Shot 2022-04-11 at 1 18 26 PM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Contributor

@megcrenshaw megcrenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Dang, a .001% chance that happens ...

@sanchitmalhotra126 sanchitmalhotra126 merged commit 6795af5 into staging Apr 13, 2022
@sanchitmalhotra126 sanchitmalhotra126 deleted the sanchit/test-helper-fix branch April 13, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants