Add PL grade type and Make levelbuilders and universal instructors able to join any section #45924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
changed the base branch from
staging
to
eptools/dani/ui-test-pl-courses
dmcavoy
commented
Apr 21, 2022
| @@ -1379,8 +1379,8 @@ describe('teacherSectionsRedux', () => { | |||
| ); | |||
| server.respondWith( | |||
| 'GET', | |||
| '/dashboardapi/sections/valid_course_offerings', | |||
| successResponse([]) | |||
| '/dashboardapi/sections/available_participant_types', | |||
There was a problem hiding this comment.
Intentional: Realized there were two calls to valid course offerings and none to available participant types in this test
dmcavoy
changed the title
| @@ -52,6 +52,8 @@ module SharedConstants | |||
|
|
|||
| STUDENT_GRADE_LEVELS = %w(K 1 2 3 4 5 6 7 8 9 10 11 12 Other).freeze | |||
|
|
|||
| PL_GRADE_VALUE = 'pl'.freeze | |||
There was a problem hiding this comment.
special values are concerning. can you help me understand why this is necessary, rather than using other properties of the section to determine whether it is a PL section?
There was a problem hiding this comment.
after offline conversation, it sounds like we will not have logic predicated on this field and it is just needed for RED purposes. I think this would be great to capture in a comment
There was a problem hiding this comment.
also, having a validation here eliminates my worry about duplicate state getting out of sync 👍
davidsbailey
approved these changes
Apr 21, 2022
| participant_type 'facilitator' | ||
| grade 'pl' | ||
| login_type 'email' | ||
| end |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change 1
To help keep the data for sections as clear as possible we are going to set the grade for professional learnign sections to 'pl' behind the scenes.
I discussed this with RED to make sure this was the best direction to support them.
Change 2
Make sure Levelbuilders and Universal Instructors can join any section.
Links
ENG plan
Testing story