NCES public schools data 2020-21 upload #45941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
requested review from
tim-dot-org and
a team
and removed request for
a team
| 'Supplemental Virtual' => 'No', | ||
| 'Virtual with face to face options' => 'Yes', | ||
| '–' => nil, | ||
| '†' => nil |
There was a problem hiding this comment.
Why do we need these characters in the hashes?
There was a problem hiding this comment.
They're in the raw data as their own values, do you have an example file, clare?
There was a problem hiding this comment.
Yes! Here are the files in drive which explain the symbols. (I removed the extra rows at the top and bottom before uploading them to S3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code to import 2020-2021 NCES data. The files containing the data are on S3. The
dry_runfield is set totrueso that I can run these manually the first time and make sure they succeed. I'll follow up with a separate PR setting that field to false so this year's data will be seeded automatically in the future.Links
Testing story
Deployment strategy
Follow-up work
I'll follow up with a PR setting the
dry_runfield to false so that this year's data will be automatically seeded in the future, and there will also be a PR to upload the private school data.Privacy
Security
Caching
PR Checklist: