Remove old categories from scripts.en.yml #45989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Apr 28, 2022
| @@ -1549,36 +1549,6 @@ class CanViewVersion < ActiveSupport::TestCase | |||
| assert_equal("Waiting for review", feedback2_result[:reviewStateLabel]) | |||
| end | |||
|
|
|||
| # This test checks that all categories that may show up in the UI have | |||
| # translation strings. | |||
| test 'all visible categories have translations' do | |||
There was a problem hiding this comment.
just confirming my understanding that this statement is now enforced by the not null requirement here?
|
I just realized the category headers in the Assignment Dropdown are not getting translated. I need to do a step before this PR. Will let you know when its ready to come back to |
|
Just checked an the translations are now live for the new way we are translating these so going to merge this now |
|
Woohoo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up work to the changes to the Assignment Dropdown.
We are no longer using these categories listed in scripts.en.yml. Instead we are using the category field on Course Offering which has been in and being translated for over 2 months (#44707). Any pattern matching by Crowdin should have happened already so this removes those old categories that are not longer needed.