Add petition call to action strings #45991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megcrenshaw
force-pushed
the
add-petition-form-strings
branch
from
d9c1957
to
a807fe3
Compare
davidsbailey
approved these changes
Apr 28, 2022
apps/i18n/common/en_us.json
Outdated
| @@ -976,6 +978,8 @@ | |||
| "histogram": "Histogram", | |||
| "homepageHeading": "My Dashboard", | |||
| "howItWorks": "How it Works (View Code)", | |||
| "iAgree": "I agree", | |||
| "iAmA": "I am a", | |||
There was a problem hiding this comment.
partial sentences will not work well for translations. I would suggest:
"I am a ..."
only slightly different, but prompts translators to move the ... in languages where the word order might be something like "a ... am I" (my new trick for this will be to imagine Yoda saying everything)
There was a problem hiding this comment.
Oh, good call. I'll do that for now, and will double check with Tess if we want to keep this label as "I am a ..." because you're right that translations will be tricky
|
Forgot to update the error strings! Updated the screenshots accordingly |
|
Unit Tests passing: https://drone.cdn-code.org/code-dot-org/code-dot-org/18303 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the strings needed for internationalization on the Petition CtA
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: