Make the Report Abuse link on the projects page into a button #46055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbergam
approved these changes
Apr 28, 2022
| display: 'inline-block' | ||
| bottomButton: { | ||
| marginTop: '30px', | ||
| marginBottom: '15px', |
There was a problem hiding this comment.
My brain wants these to be balanced, but aside from that LGTM!
| > | ||
| <h3>{i18n.reportAbuse()}</h3> | ||
| </a> | ||
| color={Button.ButtonColor.gray} |
There was a problem hiding this comment.
Also, this seems like a default button, but is there enough contrast between these two shades of grey for it to be accessible?
There was a problem hiding this comment.
(For posterity: This passes AA but not AAA. If we used 'dark_slate_grey' instead of 'charcoal' it would pass!)
There was a problem hiding this comment.
Confirmed that it meets AA standards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The request was to make this link a button that matches the other button on this page
Before:
After:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: