Update course type for virtual PL and self paced PL #46061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Apr 28, 2022
| "participant_audience": "student", | ||
| "instructor_audience": "teacher", | ||
| "participant_audience": "teacher", | ||
| "instructor_audience": "universal_instructor", |
There was a problem hiding this comment.
why this -- should a facilitator not be able to assign this course?
There was a problem hiding this comment.
Self paced courses are not designed to be assigned so we use universal instructor which pretty much only lets internal people be the instructor if they wanted to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a validation to make sure all courses that share the same course offering have the same course type (instruction type, participant audience, instructor audience). Some of our older virtual PL and self paced PL courses were built before we had those course type settings and now need to be updated to the correct settings. In order to do this we need to turn off the validation and update them all at once.
While I was doing this I also marked self-paced-pl-csd-2021 and self-paced-pl-csp-2021 as stable since we can now do that!
Once this is merged and in all in environments I will turn the validation back on (https://codedotorg.atlassian.net/browse/PLAT-1782).
Links
Confirmation from Tess
Testing story
bundle exec rake buildlocally