Create Course: Filter out unversioned families #46084
Conversation
dmcavoy
changed the title
|
Alright. Ready for review now. |
| @course_families_course_types << [cf, {instruction_type: ug.instruction_type, instructor_audience: ug.instructor_audience, participant_audience: ug.participant_audience}] | ||
| end | ||
|
|
||
| @course_families_course_types.to_h |
There was a problem hiding this comment.
can you remind me, does the return value for this method get used somewhere? here and below.
the place I would start looking is https://guides.rubyonrails.org/action_controller_overview.html, but I didn't see anything definitive. if you can't find a way that it's used, and you feel good about your test coverage, I would suggest removing it.
There was a problem hiding this comment.
I wasn't actually trying to return @course_families_course_types I just needed for follow up after setting it up to convert it to a hash. I'm going to leave this and merge it but if you have thoughts when you get back I'm happy to follow up
There was a problem hiding this comment.
This returns a hash, but does not convert the originals object into a hash, so this statement ultimately looks like it has no effect.
There was a problem hiding this comment.
Oh I see what I missed. Ok thanks I will look into this.
There was a problem hiding this comment.
Fixing it here: #46239
…t course offerings are
When creating a course (unit group or standalone unit) you are asked to pick or input a family name. The current dropdown lists all the family names available for that type of course (unit group or standalone unit). However we have families where there are one course in it and its version year is
unversionedfor those families we do not want to add other versions to the family so this PR removes the family names with unversioned courses in them from the list.This is follow up work to make sure:
Links
https://codedotorg.atlassian.net/browse/PLAT-1514
Testing story
Current Levelbuilder - New Script:
Local - New Script:
Current Levelbuilder - New Course
Local - New Course