Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Localize Timestamps on the Project Table #46090

Merged
merged 5 commits into from
May 26, 2022
Merged

Localize Timestamps on the Project Table #46090

merged 5 commits into from
May 26, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Apr 28, 2022 •
edited

The Teacher Dashboard Project Table, specifically.

locale code screenshot
en-US image
es-MX image
ar-SA image

Follow-up to #46081, which did the same thing but for the Assessments Table

Links

Jira: https://codedotorg.atlassian.net/browse/PP-116

Testing story

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Localize Timestamps on the Project Table
288e1c7 
The Teacher Dashboard Project Table, specifically.
@Hamms Hamms marked this pull request as draft April 28, 2022 20:43
@Hamms Hamms marked this pull request as ready for review April 28, 2022 23:06
@Hamms Hamms requested a review from a team May 24, 2022 00:47
hacodeorg
hacodeorg approved these changes May 25, 2022
View reviewed changes
Copy link
Contributor

@hacodeorg hacodeorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@Hamms Hamms merged commit d059abc into staging May 26, 2022
@Hamms Hamms deleted the localized-teacher-dashboard-project-table-timestamps branch May 26, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacodeorg hacodeorg hacodeorg approved these changes

Assignees
No one assigned
Labels
hackathon i18n
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @hacodeorg