New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding print icon to printing options dropdown #46099
Conversation
@@ -148,6 +149,7 @@ class Button extends React.Component { | |||
style={{...styles.icon, ...iconStyle}} | |||
/> | |||
)} | |||
{this.props.children && this.props.children} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably worth hiding the span with the text if there is no text passed in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well... either way, because nothing is actually rendered on the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
On the Lesson Overview Page
Before:
After:
On the Unit Overview Page
Before:
After:
With RTL Language:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: