Fix bug where background would show when deleting last sprite in spritelab #46100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epeach
reviewed
Apr 28, 2022
| @@ -38,7 +38,7 @@ class AnimationListItem extends React.Component { | |||
| children: PropTypes.node, | |||
| style: PropTypes.object, | |||
| allAnimationsSingleFrame: PropTypes.bool.isRequired, | |||
| spriteLab: PropTypes.bool.isRequired, | |||
| isSpriteLab: PropTypes.bool.isRequired, | |||
tim-dot-org
force-pushed
the
tim/fnf/spritelab-delete
branch
from
abe627b
to
f8ea1aa
Compare
tim-dot-org
force-pushed
the
tim/fnf/spritelab-delete
branch
from
f8ea1aa
to
a82b9b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initially loading the list of animations, we skip over any background animations when deciding which one to select first, so do the same when deleting.
Links
Testing story
added a unit test, and manually tested.
not sure how to test the error boundary dialog effectively, but the changes there are minimal