Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add behavior descriptions to translation pipeline #46135

Merged
merged 2 commits into from
May 6, 2022
Merged

Add behavior descriptions to translation pipeline #46135

merged 2 commits into from
May 6, 2022

Conversation

smusoke
Copy link
Contributor

@smusoke smusoke commented May 3, 2022 •
edited

What: Add our behavior block descriptions to the i18n sync-in process, and utilize those descriptions in our blockly model for localization.

Why: So more of our platform is translatable!

Links

Testing story

  • Locally added test translations and switched between languages
  • Ran sync-in locally to make sure behavior_descriptions were generated
  • Created a unit test for our blockly model to test localizing our default behavior blocks

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@smusoke smusoke requested a review from a team as a code owner May 3, 2022 16:07
KatieShipley
KatieShipley approved these changes May 6, 2022
View reviewed changes
Copy link
Contributor

@KatieShipley KatieShipley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@smusoke smusoke merged commit 0aacd30 into staging May 6, 2022
@smusoke smusoke deleted the fnd-1849-add-behavior-descriptions-to-translation-pipeline branch May 6, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KatieShipley KatieShipley KatieShipley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smusoke @KatieShipley