Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub script json file writes #46202

Merged
merged 1 commit into from
May 6, 2022
Merged

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented May 5, 2022

some tests for course / unit group were generating files with names like unit3.script_json, on the test machine and when run locally:
Screen Shot 2022-05-05 at 2 47 44 PM

this PR fixes the instances of this which I could find.

Testing story

running the following no longer generates stray script_json files:

Dave-MBP:~/src/cdo/dashboard (stub-script-json-file-writes)$ bundle exec spring testunit test/models/unit_group_test.rb test/controllers/courses_controller_test.rb

@davidsbailey davidsbailey marked this pull request as draft May 5, 2022 21:48
@davidsbailey davidsbailey marked this pull request as ready for review May 6, 2022 06:14
@davidsbailey davidsbailey changed the base branch from staging to lesson-description-yml May 6, 2022 06:14
@davidsbailey davidsbailey changed the title Stub script json file writes stub script json file writes May 6, 2022
@davidsbailey davidsbailey requested a review from a team May 6, 2022 06:15
Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

These all look like tests I created so TIL that add File.stubs will prevent this. Thanks!

Base automatically changed from lesson-description-yml to staging May 6, 2022 17:42
@davidsbailey davidsbailey merged commit aacc8fa into staging May 6, 2022
@davidsbailey davidsbailey deleted the stub-script-json-file-writes branch May 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants