-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneoff script to remove lesson descriptions from scripts.en.yml #46216
Conversation
This reverts commit 12671716e6e7e8b9c6ea94ccb8b96c3db683f67a.
Based on our conversation here: #46188 (comment), my understanding is there are still scripts in production relying on these strings. |
Not sure if this got resolved during stand up, but my understanding is that we are no longer using these strings as of #46143 . lmk if you want to jump on a call to discuss! |
|
||
require_relative '../../dashboard/config/environment' | ||
|
||
units_yml = File.expand_path("#{Rails.root}/config/locales/scripts.en.yml") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think its blocking but wondering if it would be safer to make sure we are on levelbuilder or local when running this script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call -- done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reran it and confirmed that it still works in local development.
for deployment strategy, I am thinking:
I can just plan to do this when I am back, but if there is reason to move forward on this sooner, it could be done in my absence. |
just noting that this has been confirmed for the 4 most recent content scoops, which are all of the scoops since #46188 reached levelbuilder. |
done in 7d35bcf |
Step 6a for PLAT-1528. Depends on #46188.
This PR adds a oneoff script which will be run on levelbuilder to remove unneeded lesson fields from scripts.en.yml, specifically:
key
,description_student
anddescription_teacher
. I am doing it this way rather than just making the change to scripts.en.yml in my PR in hopes of avoiding merge conflicts.before
after
Testing story
take a look at e4684c1 to see the results of running this script on my local machine. unfortunately, because scripts.en.yml is so big, you will have to look at the diff on your local machine. after diffing this locally, I inspected it to make sure that only the fields specified above were being removed.