Handle deleted user accounts for code review #46520
Conversation
| comments_written = CodeReviewNote.where(commenter_id: user_id) | ||
| comments_written_count = comments_written.count | ||
| comments_written.each do |comment| | ||
| comment.commenter_id = nil |
There was a problem hiding this comment.
I see this is how the Jira ticket is written, but surprised we're not deleting the contents of the comment? For future reference, @maureensturgeon could you clarify the reasoning here? Do we need to keep comments for legal reasons or something?
There was a problem hiding this comment.
This is what was requested by Mike, I think so that if someone looks back at their code review they can still see the comments that they were given
| # soft delete the code reviews of the user. This also soft deletes any comments on those reviews. | ||
| code_reviews = CodeReview.where(user_id: user_id) | ||
| code_reviews_count = code_reviews.count | ||
| code_reviews.destroy_all |
There was a problem hiding this comment.
How do the comments (associated code review notes) get deleted?
There was a problem hiding this comment.
They get deleted via the dependent: :destroy in code_review
|
Sorry for approving then raising a bunch of noise on this :) FWIW I think its fine to merge and then get clarity on the privacy question, but I don't think this would really block any other work so maybe just better to wait to clear things up. |
|
after further discussion I created this PR to allow the comment to be null. After that's in I will update this PR to null out comments on user delete. |
|
@maureensturgeon @bencodeorg updated with new logic after discussion. |
| # Table: dashboard.code_review_requests | ||
| # Table: dashboard.code_review_notes | ||
| # | ||
| test "soft deletes comments for purged user" do |
There was a problem hiding this comment.
Nit: maybe an update to this test name that notes there's some hard deleting going on this case, and aligns with the naming in the next test? Maybe "deletes code review comments on reviews owned by purged user"
| refute_nil comment.commenter | ||
| end | ||
|
|
||
| test "anonymizes and deletes code review comments written by user" do |
There was a problem hiding this comment.
I guess we don't need to anonymize them anymore since they're just getting deleted
There was a problem hiding this comment.
since we are soft-deleting I'm still anonymizing
On user account delete, do the following:
Links
Testing story
Tested via unit tests.
PR Checklist: