Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CodeReview model to use new table #46530

Merged
merged 3 commits into from
May 26, 2022

Conversation

jamescodeorg
Copy link
Contributor

@jamescodeorg jamescodeorg commented May 25, 2022

Update the CodeReview model to use the new table (added in #46528). This is currently branched off of the #46528 but will be rebased on staging after that is merged.

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jamescodeorg jamescodeorg mentioned this pull request May 25, 2022
8 tasks
@jamescodeorg jamescodeorg requested review from a team May 25, 2022 22:36
script_id: params[:scriptId],
level_id: params[:levelId]
level_id: params[:levelId],
project_level_id: params[:levelId], # TODO: send projectLevelId from the client
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the level_id and project_level_id are different, we'll send them both right? Are you waiting for the client to send the separate value to reference it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the client should always send both (even if they're the same). Yes, I'm waiting for the change on the client to send it projectLevelId;

Base automatically changed from jamescodeorg/new-code-reviews-table to staging May 26, 2022 01:48
@jamescodeorg jamescodeorg merged commit 1559a1f into staging May 26, 2022
@jamescodeorg jamescodeorg deleted the jamescodeorg/update-code-review-model branch May 26, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants