Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CSF district workshop #46544

Merged
merged 5 commits into from May 31, 2022
Merged

Add CSF district workshop #46544

merged 5 commits into from May 31, 2022

Conversation

megcrenshaw
Copy link
Contributor

Adds a new CSF workshop called "District"––this is slightly different from other CSF courses because the "Fee Information" and "Should this appear on the k-5 workshop map" are hidden.

Screen Shot 2022-05-26 at 9 53 12 AM

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@megcrenshaw megcrenshaw requested a review from a team May 26, 2022 15:07
@dmcavoy
Copy link
Contributor

dmcavoy commented May 26, 2022

Whats happening with emails for this workshop type?

@megcrenshaw
Copy link
Contributor Author

Good question. In the ticket, it specifies, "It is important that we can still enable emails and select facilitators for this workshop subject." –– this is still an option in the UI. My guess is that the standard email logic will be used here if they are enabled on the site

@megcrenshaw
Copy link
Contributor Author

Just checked in with Tess about this. It should behave like the other CSF courses––Pd::WorkshopMailer already does this!

Copy link
Contributor

@dmcavoy dmcavoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like the email stuff is taken care of so this good to me from my knowledge of the workshop dashboard

@megcrenshaw megcrenshaw merged commit 3ad211b into staging May 31, 2022
@megcrenshaw megcrenshaw deleted the add-district-workshop branch May 31, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants