Clean up environment-specific instructions in SETUP.md #46750
Conversation
Specifically: - The "general" instructions section had several M1-mac-specific instructions in it; move them into the mac-specific section - Add instructions for an Ubuntu 22.04-specific issue
|
|
||
| 8. `bundle install` | ||
| 1. `bundle install` |
There was a problem hiding this comment.
pretty sure we can't run bundle install on M1 without the lockfile changes.
However, I've got another PR that will hopefully remove this workaround.
There was a problem hiding this comment.
Right, but the directions for the lockfile changes are in the section referenced by this earlier step:
1. Install OS-specific prerequisites
- See the appropriate section below: [OS X](#os-x-monterey---including-apple-silicon-m1), [Ubuntu](#ubuntu-1804-download-iso), [Windows](#windows)
This section of the instructions is for general instructions which apply to all operating system environments; OS-specific instructions should go in the OS-specific sections
There was a problem hiding this comment.
oh, i missed one of the 'expand' sections in the diff and it was hiding the M1 heading 🤦
There was a problem hiding this comment.
Oh, I should have also mentioned:
Some of the instructions I moved, but some of them I went to move and realized they already existed both in the place I was moving them from and the place I was moving them to, so I just removed them.
|
|
||
| 8. `bundle install` | ||
| 1. `bundle install` |
There was a problem hiding this comment.
oh, i missed one of the 'expand' sections in the diff and it was hiding the M1 heading 🤦
Specifically:
Also, we were manually maintaining the numbers of the steps in code, which makes refactoring like this more tedious. By instead using a consistent notation, we can let Markdown handle the numbering for us. Because the numbering change is somewhat noisy, I recommend reviewing this PR commit-by-commit:
PR Checklist: