Auto-correct some Rails Rubocop violations #46793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically, run:
Followed by:
The result of this is that the following desired rules are re-enabled:
Rails/ActiveRecordAliases
Rails/ApplicationRecord
Rails/FindById
Rails/IndexBy
Rails/SafeNavigationWithBlank
Rails/RedundantForeignKey
Rails/WhereNot
We also incidentally re-enable the
Lint/Debugger
rule. Not sure why this one was disabled in the first place, but I'm glad to see it gone!PR Checklist: