New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Misc Rubocop Fixes #46826

Merged

Hamms merged 3 commits into staging from fix-some-rubocop-errors

Jun 21, 2022

Contributor

Hamms commented Jun 10, 2022 •

edited

Specifically, fix violations of and reenable the following rules:

Layout/SpaceInsideBlockBraces
Style/MultipleComparison
Style/RedundantSelfAssignmentBranch
Style/WhileUntilModifier

PR Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked

Hamms added 2 commits

June 10, 2022 12:31


          Manually fix up a few misc rubocop errors

76ebc95


          update rubocop after fixes

09c9370

Hamms added the code-hygiene label

Hamms requested a review from a team

June 13, 2022 18:56


          Merge branch 'staging' into fix-some-rubocop-errors

89ff7d8

cat5inthecradle approved these changes

View reviewed changes

Hamms merged commit 665858d into staging

Hamms deleted the fix-some-rubocop-errors branch

June 21, 2022 17:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment