Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IRB Customizations With .irbrc #46849

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Jun 13, 2022

Rather than in dashboard code. The primary reason to avoid updating console.rb to conform to Zeitwerk's expectations, but the secondary reason is to avoid adding a file to lib/ which has side effects on being included. This code is not something we ever want to invoke as an actual code path, so we shouldn't treat it as such.

Links

Testing story

Tested locally:

[~/code-dot-org (implement-irb-customization-as-dotfile)]$ bin/dashboard-console
Running via Spring preloader in process 76862
Loading development environment (Rails 6.0.4.1)
irb: warn: can't alias context from irb_context.
[development] dashboard >

[~/code-dot-org (implement-irb-customization-as-dotfile)]$ cd dashboard/
[~/code-dot-org/dashboard (implement-irb-customization-as-dotfile)]$ ../bin/dashboard-console
Running via Spring preloader in process 76928
Loading development environment (Rails 6.0.4.1)
irb: warn: can't alias context from irb_context.
[development] dashboard >

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Rather than in dashboard code. The primary reason to avoid updating `console.rb` to conform to Zeitwerk's expectations, but the secondary reason is to avoid adding a file to `lib/` which has side effects on being included. This code is not something we ever want to invoke as an actual code path, so we shouldn't treat it as such.
@Hamms Hamms requested a review from a team June 13, 2022 23:06
Copy link
Contributor

@cat5inthecradle cat5inthecradle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't fully understand how rails console works, but this PR makes sense otherwise.

@Hamms Hamms merged commit 5668441 into staging Jun 17, 2022
@Hamms Hamms deleted the implement-irb-customization-as-dotfile branch June 17, 2022 18:18
@Hamms Hamms mentioned this pull request Jun 22, 2022
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants