Neighborhood: add show/hide painter and buckets #46865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorporate signals to show and hide the painter and paint buckets in the neighborhood. These signals were added to maze in this PR and this PR, and included in maze version
2.15.0. Show/hide painter was already available in the api, and show/hide buckets was added in this PR, and has been deployed to javabuilder. The constants for the signals were already inconstants.js.Screen recordings
These two videos show the same code, the first without showing and hiding buckets, and the second hides the painters and buckets after creating them, then shows them after all operations are complete.
Visible painters and buckets
painters-buckets-shown.mp4
Hide, then show painters and buckets
painters-buckets-hidden.mp4
Links
Testing story
Tested locally