added hover action to expand/collapse buttons and removed onclick on Watcher tab in Game/App lab #46887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisher-alice
changed the title
megcrenshaw
approved these changes
Jun 17, 2022
jmkulwik
reviewed
Jun 17, 2022
| @@ -631,7 +637,7 @@ const styles = { | |||
| fontSize: 18, | |||
| ':hover': { | |||
| cursor: 'pointer', | |||
| color: 'white' | |||
| color: color.white | |||
There was a problem hiding this comment.
Setting the hover color for the bottom buttons as white was the right call after looking at the code. Given that the Jira ticket specified a black hover color, put a brief note in the PR description explaining why you went with white in this case. That will help build understanding and shared context in case someone sees the change in the future and wants to adjust it to a different color.
There was a problem hiding this comment.
Thanks for the feedback! Just edited the comment and included rationale for why I went with white.
jmkulwik
approved these changes
Jun 17, 2022
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
-Added color change hover action to expand/collapse buttons on bottom of page (Debug console and Watcher area)
Although the Jira ticket specified a black hover color, I chose to change color to white since the code already included the color change to white on hover action for both buttons. Added a span around the the two icons allowed color of icons and pointer change to occur.
-Although not in Jira ticket, I also removed onclick on Watcher tab so that onclick for Watcher area active only on expand/collapse button.
Video of changes: https://youtu.be/MEGaCbvkpqs
jira ticket: https://codedotorg.atlassian.net/browse/STAR-2326?atlOrigin=eyJpIjoiMDQ1YWJjZWJmYTFlNDk1NDhjYjYyNjU2ZGQ4YTE0YTYiLCJwIjoiaiJ9
Follow-up work
Noticed that for Toolbox area at top of page, onclick/hover is active on Show Toolbox (when Toolbox is collapsed) but not on Toolbox (when Toolbox is expanded).
Originally, The Watchers tab had onclick whether it was expanded (displaying 'Watchers') or collapsed (displaying 'Show Watchers'). However, the hover action for pointer was not on the 'Show Watchers' as it is on the Show Toolbox.
Next task could be to add hover pointer for 'Show Watchers' label.