Added 'Verified Teacher' string and label added in account settings... #46888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we capitalize the "v" in "verified"? |
mgc1194
changed the title
daynew
approved these changes
Jun 16, 2022
| @@ -15,6 +15,9 @@ | |||
| - email_mismatch = current_user.errors.delete(:email_mismatch) | |||
| - current_user.reload if email_mismatch.present? | |||
| = render "devise/shared/error_messages", resource: resource | |||
| - if current_user.permission?(UserPermission::AUTHORIZED_TEACHER) | |||
| .field | |||
| = f.label '✔ '+t('activerecord.attributes.user.verified_teacher'), class: 'label-bold', style: 'color:green; text-transform: capitalize'; | |||
There was a problem hiding this comment.
Usually it can be buggy to concatinate two strings together because the behaviour with RTL languages is hard to predict. Please verify this still looks good in a RTL language (Arabic / ar-SA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for verified teachers.
Our Customer Support manager has asked if we can add some sort of explicit indicator on the Account Settings page, clearly stating "Verified! " or similar, to reduce confusion. Sometimes we verify folks, but their provided email address (under their Code.org account) isn’t a real working accessible inbox, so they’re verified, but they don’t receive our email letting them know. In general, there’s no indicator on the site stating “you are verified.”
Acceptance criteria
Add “Verified teacher” to the i18n sync
A green checkmark icon (not an interactive component) and the string “Verified teacher” appear below the “Edit Account Details” title on http://studio.code.org/users/edit if the User has an authorized_teacher UserPermission.
Links
Testing story
Test Performed
Account settings has been tested locally for the following scenarios:
All tests were successful.
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: