Remove Radium from JavalabSettings #47463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddiedierker
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
JavalabSettingspasses an object with a pseudoclass key (:hover) toJavalabButton, but does not require Radium itself, as I understand it?
looking at this component, that's my understanding as well. it looks like the only styles that require radium are being passed to JavalabButton, which loads radium itself.
also, great idea to remove the unused style prop! we'll need to slowly move away from that, so this is awesome to see.
Base automatically changed from
ben/javalab-file-explorer-remove-radium
to
staging
August 4, 2022 15:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavalabSettingspasses an object with a pseudoclass key (:hover) toJavalabButton, but does not require Radium itself, as I understand it? It'd probably be good to have someone double check my understanding though. I also remove the optionalstyleprop, which isn't used (just to clean up/hopefully hedge against future style prop passing).Testing story
Tested manually that JavalabSettings (the "Settings" button at the bottom right of the Javalab console) continued to function as expected.