Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Support for Ruby 2.5 #47643

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Drop Support for Ruby 2.5 #47643

merged 1 commit into from
Aug 29, 2022

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Aug 16, 2022

Follow-up to #47406, which added support for Ruby 2.6. Also stop attempting to delete 2.5 from all our servers, now that it has been.

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms
Drop Support for Ruby 2.5
c71bca6 
And stop attempting to delete it from all our servers, now that it has been.
@Hamms Hamms added the Ruby Update Everything related to work to update the version of Ruby our codebase runs on label Aug 16, 2022
@Hamms Hamms requested review from a team August 16, 2022 23:01
bethanyaconnor
bethanyaconnor approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super familiar with this area but this makes sense to me

@Hamms Hamms merged commit 9b7755e into staging Aug 29, 2022
@Hamms Hamms deleted the drop-ruby-2.5 branch August 29, 2022 19:43
This was referenced Aug 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshc sureshc sureshc approved these changes

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
Ruby Update Everything related to work to update the version of Ruby our codebase runs on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Hamms @sureshc @bethanyaconnor