Playlab: Fix another JS error #47756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new highest error in New Relic was for a spike for just a couple users, when throwing an error that we could instead just ignore.
bencodeorg
reviewed
Aug 23, 2022
| @@ -5653,7 +5653,7 @@ Studio.setSprite = function(opts) { | |||
|
|
|||
| var spriteIndex = opts.spriteIndex; | |||
| if (spriteIndex < 0 || spriteIndex >= Studio.spriteCount) { | |||
| throw new RangeError('Incorrect parameter: ' + spriteIndex); | |||
There was a problem hiding this comment.
Does the student see anything indicating the mistake they made when this error is thrown currently? Or are they too young so we don't show anything anyway?
There was a problem hiding this comment.
Great question. No, the student experience didn't change from my testing. Both before and after, the program would just stop running with the offending block highlighted. But before, we'd be firing an exception every frame.
bencodeorg
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new highest error in New Relic was a brief spike generated by just a couple users, when throwing an error that we could instead just ignore.