Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "Remove prettier"" #47771

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

megcrenshaw
Copy link
Contributor

Reverts #47763

@megcrenshaw megcrenshaw force-pushed the revert-47763-revert-47758-remove-prettier branch from 74c8526 to e2bb193 Compare August 23, 2022 17:28
@megcrenshaw megcrenshaw force-pushed the revert-47763-revert-47758-remove-prettier branch from e2bb193 to a3fa7bb Compare August 23, 2022 19:07
@megcrenshaw megcrenshaw requested a review from a team August 23, 2022 19:26
Copy link
Contributor

@mikeharv mikeharv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work Meg!

@maddiedierker
Copy link
Contributor

linting succeeded on the unit test container, so you're good to merge this! 🚀 after this is merged, we should let folks know to merge staging into any branches they're working on and run yarn lint just for good measure

@megcrenshaw megcrenshaw merged commit 186cf66 into staging Aug 23, 2022
@megcrenshaw megcrenshaw deleted the revert-47763-revert-47758-remove-prettier branch August 23, 2022 20:20
@megcrenshaw
Copy link
Contributor Author

linting succeeded on the unit test container, so you're good to merge this! 🚀 after this is merged, we should let folks know to merge staging into any branches they're working on and run yarn lint just for good measure

Excellent! Should we wait until this succeeds for the message to everyone?

@maddiedierker
Copy link
Contributor

Should we wait until this succeeds for the message to everyone?

yeah, that's probably a good idea. @mikeharv we should wait to open staging until a staging build has succeeded with this change, too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants