Fix button text and dismissible not showing for announcements #47833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Aug 29, 2022
| announcement.visibility | ||
| announcement.visibility, | ||
| announcement.dismissible, | ||
| announcement.buttonText |
There was a problem hiding this comment.
this is quite a lot of positional arguments. you could reduce the risk of error here by using object destructuring in the method definition:
export const addAnnouncement = ({
notice,
details,
link,
type,
visibility,
dismissible,
buttonText
}) => ({
store.dispatch(addAnnouncement(announcement))
There was a problem hiding this comment.
Oh cool! Ya I'll do that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dan reported that the button text was showing in the preview on the unit edit page but not on the unit overview page. (slack) . I traced this back to when we set up the redux store for announcements. I did not update the add announcements in my last PR to account for the new fields.
I tested it locally and now the fields are reflected on the Unit Overview page.
Links
https://codedotorg.atlassian.net/browse/PLAT-1946
Testing story