Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused /v2/poste/send-message route from pegasus #47925

Merged
merged 3 commits into from
Sep 9, 2022

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 2, 2022

One of the things marked for removal in https://docs.google.com/spreadsheets/d/1-qAM-vMnc5PZXIJSiIArZGGWTQTiDbepQUXR5ZBxvB4/edit#gid=0 is the /v2/poste/send-message route. This PR removes that route.

this is just speculation, but I suspect this route may be left over from when we used to send batches of marketing emails through poste. now we send those marketing emails through pardot.

Testing story

  • code search to make sure there are no remaining references to /v2/poste/send-message
  • searched ELB logs to make sure we are not getting any requests from dashboard to this url
  • existing pegasus tests should help ensure that removing the csrf stuff didn't break anything unexpectedly

@davidsbailey davidsbailey marked this pull request as ready for review September 2, 2022 06:08
@davidsbailey davidsbailey changed the title No poste send message remove unused /v2/poste/send-message route from pegasus Sep 2, 2022
Copy link
Contributor

@pablo-code-org pablo-code-org left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked to the team, and we all agree it is good.

@davidsbailey
Copy link
Member Author

excellent, thanks so much @pablo-code-org for all your help with reviews!

@davidsbailey davidsbailey merged commit 31dd980 into staging Sep 9, 2022
@davidsbailey davidsbailey deleted the no-poste-send-message branch September 9, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants