Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n sync In & Up 09/07 #47981

Merged
merged 4 commits into from
Sep 9, 2022
Merged

I18n sync In & Up 09/07 #47981

merged 4 commits into from
Sep 9, 2022

Conversation

deploy-code-org
Copy link
Contributor

I18n Sync In & Up

This PR contains all changes to internationalization source strings made since the last sync (usually a week).

To Review:

  1. Look through the changes in each of the commits and verify that all changes are expected

    • We expect content changes to come in on a regular basis; individual strings will get updated, added, and deleted.

    • We do not usually expect to see "comprehensive" changes - or changes that apply to large numbers of strings or whole categories of strings all at once - unless we have made specific code changes.

  2. Notify the International Partners team about any changes that might appear to manifest as "lost translations"

    • For example: https://github.com/code-dot-org/code-dot-org/pull/31031/files#diff-aa1910a8cf8f9290ae3baf7e39dbae3eL397-R398

      This is a change that added new strings (with both new keys and new content) and simultaneously removed some very similar old ones; we can reasonably infer that the intent here was to swap the new strings out for the old ones. Unfortunately, because the swap also included a content change to the strings the crowdin duplication system won't automatically apply translations to the new strings and so they will need to be manually re-translated.

To Deploy:

Once one or two people have reviewed and approved this change and the tests are passing, ship it!

It's not necessary to wait for everyone on the team to review.

@deploy-code-org deploy-code-org requested a review from a team as a code owner September 7, 2022 20:20
@wilkie
Copy link
Contributor

wilkie commented Sep 9, 2022

I re-ran the build since one unit test was failing but then canceled it. It would fail again. That test was just fixed via an upstream commit recently.

@deploy-code-org
Copy link
Contributor Author

This comment is created by running: bin/i18n/analyze_pr.rb -p 47981 -c

Top 5/28 files sorted by the number of changes:

  • i18n/locales/source/course_content/2022/express-2022.json, 5978 changes (5978 additions, 0 deletions).
  • i18n/locales/source/course_content/2022/coursef-2022.json, 4036 changes (4036 additions, 0 deletions).
  • i18n/locales/source/course_content/2022/coursee-2022.json, 2099 changes (2099 additions, 0 deletions).
  • i18n/locales/source/course_content/2022/coursed-2022.json, 1482 changes (1482 additions, 0 deletions).
  • i18n/locales/source/course_content/2022/coursec-2022.json, 1248 changes (1248 additions, 0 deletions).

Top 4/4 commits sorted by the number of changes:

  • Commit: course content i18n sync
    • 17033 changes (17025 additions, 8 deletions).
    • 15 files changed.
    • File with the most changes: i18n/locales/source/course_content/2022/express-2022.json, 5978 changes (5978 additions, 0 deletions).
  • Commit: dashboard i18n sync
    • 245 changes (191 additions, 54 deletions).
    • 9 files changed.
    • File with the most changes: i18n/locales/source/dashboard/scripts.yml, 213 changes (161 additions, 52 deletions).
  • Commit: hoc i18n sync
    • 80 changes (42 additions, 38 deletions).
    • 3 files changed.
    • File with the most changes: i18n/locales/source/hourofcode/en.yml, 54 changes (30 additions, 24 deletions).
  • Commit: apps i18n sync
    • 11 changes (10 additions, 1 deletions).
    • 1 files changed.
    • File with the most changes: i18n/locales/source/blockly-mooc/common.json, 11 changes (10 additions, 1 deletions).

@wilkie wilkie merged commit e592d04 into staging Sep 9, 2022
@wilkie wilkie deleted the i18n-sync-in-up-09-07-2022 branch September 9, 2022 17:08
@wilkie
Copy link
Contributor

wilkie commented Sep 9, 2022

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants