Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n sync Down & Out 09/08 #48024

Merged
merged 90 commits into from
Sep 9, 2022
Merged

I18n sync Down & Out 09/08 #48024

merged 90 commits into from
Sep 9, 2022

Conversation

deploy-code-org
Copy link
Contributor

I18n Sync Down & Out

This PR contains all changes to translations made since the last sync (usually a week).

To Review:

Look through the changes in each of the commits and verify that all changes are expected. Note that it is not necessary to review every single "dashboard i18n update" commit. These commits are batched by language to make it easier to review just a couple commits in this category.

Things to Note:

  • We expect translation changes to come in on a regular basis; new strings will be translated, existing translations will be updated, and source string removals will result in translations for those strings also being removed.

  • We expect translations to arrive in large batches, so don't worry if you see a large group of changes in a specific language.

  • We do not usually expect to see a large number of formatting changes, or batches of changes that apply to strings in every single language. If you see this, it usually means either that a code change went in or that something broke.

Known Issues:

  • If the CI unit tests fail at the grunt messages:all step, they will typically fail with a message like:

    [2019-10-04 02:38:57] Running "messages:all" (messages) task
    [2019-10-04 02:39:00] Warning: Error processing localization file i18n/common/zh_tw.json: SyntaxError: Expected [0-9a-zA-Z$_] but "\u8A0A" found. Use --force to continue. 
    

    This usually means that a translator has translated one of the MessageFormat variables. In this case, you should find and fix the offending translation in crowdin, and then manually update the associated strings in i18n/locales and apps/i18n.

    See ab3e5d1 and 0fca376 for an example.

To Deploy:

Once one or two people have reviewed and approved this change and the tests are passing, ship it!

It's not necessary to wait for everyone on the team to review.

@deploy-code-org deploy-code-org requested a review from a team as a code owner September 8, 2022 23:14
@deploy-code-org
Copy link
Contributor Author

This comment is created by running: bin/i18n/analyze_pr.rb -p 48024 -c

Top 5/2133 files sorted by the number of changes:

  • bin/i18n/crowdin/codeorg_etags.json, 57758 changes (29711 additions, 28047 deletions).
  • i18n/locales/source/course_content/2022/express-2022.json, 5978 changes (5978 additions, 0 deletions).
  • dashboard/config/locales/activity_sections.fa-IR.json, 5694 changes (5694 additions, 0 deletions).
  • bin/i18n/crowdin/hour-of-code_etags.json, 5264 changes (2632 additions, 2632 deletions).
  • dashboard/config/locales/activity_sections.fr-FR.json, 4983 changes (4653 additions, 330 deletions).

Top 5/90 commits sorted by the number of changes:

  • Commit: etags updates
    • 63374 changes (32519 additions, 30855 deletions).
    • 4 files changed.
    • File with the most changes: bin/i18n/crowdin/codeorg_etags.json, 57758 changes (29711 additions, 28047 deletions).
  • Commit: dashboard i18n updates - Slovak
    • 29246 changes (25406 additions, 3840 deletions).
    • 33 files changed.
    • File with the most changes: dashboard/config/locales/dsls.sk-SK.yml, 11176 changes (7677 additions, 3499 deletions).
  • Commit: dashboard i18n updates - French
    • 24167 changes (20214 additions, 3953 deletions).
    • 36 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.fr-FR.json, 4983 changes (4653 additions, 330 deletions).
  • Commit: dashboard i18n updates - Spanish, Mexico
    • 21114 changes (20186 additions, 928 deletions).
    • 32 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.es-MX.json, 4566 changes (4564 additions, 2 deletions).
  • Commit: dashboard i18n updates - I18n Pseudo-Language
    • 20547 changes (20238 additions, 309 deletions).
    • 39 files changed.
    • File with the most changes: dashboard/config/locales/activity_sections.in-TL.json, 5694 changes (5694 additions, 0 deletions).

@wilkie wilkie merged commit 7a62d80 into staging Sep 9, 2022
@wilkie wilkie deleted the i18n-sync-down-out-09-08-2022 branch September 9, 2022 17:09
@wilkie
Copy link
Contributor

wilkie commented Sep 9, 2022

🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants