Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by #48008 #48029

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Conversation

bethanyaconnor
Copy link
Contributor

Links

Testing story

Deployment strategy

Follow-up work

Privacy

Security

Caching

PR Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review September 9, 2022 14:26
@bethanyaconnor
Copy link
Contributor Author

Merging ahead of review to unblock Drone now that Drone unit tests have passed. Dashboard tests definitely ran this time:

[test] Files affecting dashboard    tests *modified* from origin/staging. Starting tests. Changed files:
--
4847 | [test]
4848 | dashboard/test/integration/routes_test.rb
4849 | [test] Running dashboard tests...

I noticed in #46857 that the cookbook tests were also changed so I also updated those but couldn't test them locally. I'll kick off a DTT immediately after I merge this.

@bethanyaconnor bethanyaconnor merged commit 972d479 into staging Sep 9, 2022
@bethanyaconnor bethanyaconnor deleted the bethany/fix-unit-tests-0909 branch September 9, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant