Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run dashboard tests when http_cache.rb changes #48033

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Sep 9, 2022

additional follow-up from #48008

Testing story

not tested, because drone already runs dashboard tests as a result of me touching this rake file. however the drone run did at least make sure that rake test:changed:dashboard was not broken by this change.

Copy link
Contributor

@bethanyaconnor bethanyaconnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidsbailey davidsbailey marked this pull request as ready for review September 9, 2022 19:31
@davidsbailey davidsbailey merged commit 4fa2ef2 into staging Sep 9, 2022
@davidsbailey davidsbailey deleted the http-cache-dashboard-changed branch September 9, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants