Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Music prototype: separate blockly renderers #48663

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Music prototype: separate blockly renderers #48663

merged 1 commit into from
Oct 17, 2022

Conversation

breville
Copy link
Member

No description provided.

@breville breville merged commit fbd972f into music-prototype Oct 17, 2022
@breville breville deleted the music-prototype-separate-renderers branch October 17, 2022 05:36
sanchitmalhotra126
sanchitmalhotra126 reviewed Oct 17, 2022
View reviewed changes
Copy link
Contributor

@sanchitmalhotra126 sanchitmalhotra126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be curious to hear more about this change. Does this affect our other blockly labs?

@breville
Copy link
Member Author

I had noticed that, without this change, the music-prototype branch had switched all Google Blockly levels (e.g. https://studio.code.org/flappy/10) to the zelos renderer, but with this change, only music gets it. I hope @mikeharv has more thoughts on the right way to do this split, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanchitmalhotra126 sanchitmalhotra126 sanchitmalhotra126 left review comments

@mikeharv mikeharv Awaiting requested review from mikeharv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@breville @sanchitmalhotra126