Update statuses in detail view for teacher apps #48804
Conversation
megcrenshaw
force-pushed
the
update-teacher-app-statuses
branch
from
dc3ba79
to
9355686
Compare
| @@ -4,7 +4,7 @@ import {FormGroup} from 'react-bootstrap'; | |||
| import Select from 'react-select'; | |||
|
|
|||
| // update this to lock scholarships so that scholarship status can't be updated via the UI. | |||
| const locked = true; | |||
| const locked = false; | |||
There was a problem hiding this comment.
This was part of shutting down last year's applications. I've gotten approval to unlock this.
| @@ -20,7 +21,7 @@ describe('SummaryTable', () => { | |||
| assert( | |||
| wrapper.containsMatchingElement( | |||
| <tr> | |||
| <td>Accepted</td> | |||
There was a problem hiding this comment.
This was failing because the field is now Accepted (auto-email)
| if (this.state.status !== 'incomplete') { | ||
| statusesToHide.push('incomplete'); | ||
| } | ||
|
|
There was a problem hiding this comment.
This is much more readable now! Creative way of setting this up :D
|
Hey Meg - I'm realizing that the doc used both "Needs Admin Approval" and "Awaiting Admin Approval" which is my bad. I'm thinking we probably want to just use one. I'm leaning toward standardizing on "Awaiting Admin Approval" what do you think? Also @TurnerRiley what do you think? |
|
Either way works for me. Needs Admin Approval will be shorter on the front-end, but Awaiting Admin Approval sounds nicer imo. Changing it on the front-end will be easy, and it's already awaiting-admin-approval on the backend –– should I go ahead and make it all Awaiting Admin Approval? |
|
Yes lets go ahead and use Awaiting Admin Approval everywhere. I will update the doc to reflect that. Thank you! |
|
Sounds great! Just updated 👍 |
I agree, "Awaiting Admin Approval" sounds good! |
This fulfills requirement two in Update Application Statuses.
Statuses in detail view:
Statuses in detail view when principal approval is not required:
Trying to save before setting registration status:
Successfully changing the application statuses:
Links
Testing story
Deployment strategy
Follow-up work
Privacy
Security
Caching
PR Checklist: